Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move connectionset from analyzer and protocols from synthesizer #10

Merged
merged 20 commits into from
Mar 21, 2024
Merged

Move connectionset from analyzer and protocols from synthesizer #10

merged 20 commits into from
Mar 21, 2024

Conversation

elazarg
Copy link
Member

@elazarg elazarg commented Mar 6, 2024 •
edited
Loading

Reopening #8.

Main differences from the version in the synthesizer:

  • Remove mutating methods, replace with convenience constructors: All(), None(), TCPorUDPConnection(), ICMPConnection()
  • Remove AllowAll field
  • Dedicated StatefulState type
  • Use netp.ProtocolString instead of ProtocolStr
  • switchSrcDstPortsOnTCP() only actually switch dimensions when they differ
  • Sort protocol strings lexicographically on output: ICMP,TCP,UDP
  • Rename:
    • ConnectionSet => Set
    • getProtocolStr() => protocolStringFromCode()
    • getDimensionDomain() => entireDimension()
    • AllowAll => IsAll()
    • Intersection() => Intersect()
    • ConnWithStatefulness() => WithStatefulness()
    • getDimensionStr() => getDimensionString()
    • Except() => ExceptCidrs()

@elazarg elazarg requested a review from adisos March 6, 2024 14:05
@elazarg elazarg mentioned this pull request Mar 6, 2024
Closed
@adisos adisos requested a review from zivnevo March 7, 2024 06:48
adisos
adisos reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

zivnevo
zivnevo requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the copyright comment at the top for all source files

/*
Copyright 2020- IBM Inc. All Rights Reserved.

SPDX-License-Identifier: Apache-2.0
*/

adisos
adisos reviewed Mar 10, 2024
View reviewed changes
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Added just a small comment for now

pkg/connection/connectionset.go Outdated Show resolved Hide resolved
adisos
adisos reviewed Mar 11, 2024
View reviewed changes
pkg/ipblock/ipblock.go Outdated Show resolved Hide resolved
adisos
adisos reviewed Mar 11, 2024
View reviewed changes
pkg/ipblock/ipblock_test.go Outdated Show resolved Hide resolved
@adisos adisos requested a review from zivnevo March 11, 2024 06:58
This was referenced Mar 12, 2024
Merged
Merged
Merged
@elazarg elazarg mentioned this pull request Mar 12, 2024
Merged
Elazar Gershuni added 3 commits March 19, 2024 12:51
@elazarg elazarg requested a review from adisos March 20, 2024 11:26
Elazar Gershuni added 2 commits March 20, 2024 13:31
adisos
adisos reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one small comment

pkg/connection/connectionset.go Outdated Show resolved Hide resolved
remove stale comment
de96981 
Signed-off-by: Elazar Gershuni <[email protected]>
zivnevo
zivnevo requested changes Mar 21, 2024
View reviewed changes
pkg/connection/connectionset.go Outdated Show resolved Hide resolved
pkg/interval/intervalset.go Show resolved Hide resolved
pkg/interval/intervalset.go Show resolved Hide resolved
pkg/hypercube/hypercubeset_test.go Outdated Show resolved Hide resolved
pkg/ipblock/ipblock.go Outdated Show resolved Hide resolved
Elazar Gershuni added 2 commits March 21, 2024 12:09
@elazarg
Copy link
Member Author

elazarg commented Mar 21, 2024

I realized that the dimension types encode the order of the dimensions, which makes it harder to know what depends on the order of the dimensions, and contradicts the comment preceding dimensionsList:

// this should be the only place where the order is hard-coded

So the last commit changes the type of Dimension from int to string; the index of each dimension in a cube is looked up in the slice dimensionsList. It also delegates most of the work of swapping dimensions to the underlying hypercube set.

@elazarg elazarg requested a review from zivnevo March 21, 2024 10:19
zivnevo
zivnevo reviewed Mar 21, 2024
View reviewed changes
pkg/ipblock/ipblock.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an (exported?) global var here representing the full range of IP addresses?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea

handle edge case
5dab358 
Signed-off-by: Elazar Gershuni <[email protected]>
test SwapDimensions
84681d5 
Signed-off-by: Elazar Gershuni <[email protected]>
@elazarg elazarg merged commit fc2b1ae into main Mar 21, 2024
4 checks passed
@elazarg elazarg deleted the connectionset-2 branch March 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elazarg @zivnevo @adisos